Add missing TimerRemaining class definition to Implicit Index Access example in C#13 documentation. #44018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
BillWagner
approved these changes
Dec 19, 2024
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Thanks again @shethaadit
I'll 
now.
tmds
reviewed
Dec 19, 2024
| ```csharp | ||
| public class TimerRemaining | ||
| { | ||
| public int[] buffer { get; set; } = new int[10]; |
Member
There was a problem hiding this comment.
nit: the setter could be left out which would emphase the buffer = below isn't doing a set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the example in the Implicit Index Access section of the C# 13 documentation to include the missing definition of the
TimerRemainingclass. The current example assumes the existence of abufferarray but does not clarify its source, which may lead to confusion.Changes Made:
Added the
TimerRemainingclass definition, including thebufferproperty initialized with a length of 10.Updated the accompanying text to clarify that the
TimerRemainingclass includes thebufferarray and how the "from the end" index operator (^) is applied to assign values to it.These changes ensure the example is self-contained and easier for readers to understand.
Fixes #44001
Internal previews